skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) by os-litant · Pull Request #14585 · objectstack-ai/objectstack

os-litant · 2026-09-02T13:24:26Z

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

file	change
`skills/objectstack-query/evals/README.md`	deleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
`scripts/check-skills-token-ratchet.mjs`	one row dropped: `['skills/objectstack-query/evals/README.md', 567]` — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha `3e1a218e`

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

command	exit	result
`node scripts/check-ci-filter-parity.mjs`	0	all 130 declared cross-package glob(s) (92 unique) covered by `core`/`crosspkg`, every `crosspkg` entry still covers one, `test` job's `if:` names both filters
`node scripts/check-cross-package-test-inputs.mjs`	0	25 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
`node scripts/check-shard-attestation.mjs`	0	2 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
`node scripts/check-skills-token-ratchet.mjs`	0	36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
`node scripts/check-test-completeness.mjs`	3	PREREQUISITE NOT MET — no saved `turbo run test` log named; NOT MEASURED, not a finding
`node scripts/pm/bare-root-worklist.mjs --self-test`	0	self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
`pnpm --filter @objectstack/lint run check:doc-formula-expressions`	3	PREREQUISITE NOT MET — `@objectstack/formula` not built; this flight touches neither formula nor its docs
`pnpm check:agent-test-spelling`	0	self-test + live sweep clean
`pnpm check:bash32-floor`	0	26 tracked shell file(s), no bash4+ construct outside guarded positions
`pnpm check:cli-command-ids`	0	315 command-id literal(s) across 112 file(s) all resolve
`pnpm check:corpus-claim-drift`	0	1 rule row, 2 baselined file(s), clean
`pnpm check:cross-package-test-inputs`	0	117 self-test cases pass; 25 package(s) declared, all covered
`pnpm check:doc-authoring`	0	14491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
`pnpm check:entry-guard`	0	199 scripts/ file(s), 150 export bindings, all safe
`pnpm check:parse-guard`	0	clean
`pnpm check:pm-dispatch-gates`	0	dispatch-gates self-test: 1240 cases pass
`pnpm check:pm-governed-merges`	0	self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
`pnpm check:pnpm-filter-targets`	0	142/181 `--filter` occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
`pnpm check:ratchet-remedy-authority`	0	184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
`pnpm check:role-word`	0	224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
`pnpm check:skill-compatibility`	0	11 SKILL.md file(s) reconciled against 78 workspace packages
`pnpm check:skill-frame-sync`	0	4 copies of the decision frame structurally isomorphic across 3 files
`pnpm check:skill-identifier-liveness`	0	Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
`pnpm check:watch-hint-literal`	0	45 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2): node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1

Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. Deletes skills/objectstack-query/evals/README.md (558-token stub of nine "Planned Evals" scenarios never built) and drops its row from scripts/check-skills-token-ratchet.mjs -- the only edit to that script this flight makes. Fixes #14302, round 2. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1

github-actions Bot added the size/s label Sep 2, 2026

os-litant added skip-changeset PR has no user-facing published change; bypasses the changeset gate and removed size/s labels Sep 2, 2026 — with Claude

github-actions Bot added the documentation Improvements or additions to documentation label Sep 2, 2026

github-actions Bot mentioned this pull request Sep 2, 2026

[Half-state patrol] check-half-states live sweep — generated view (please pin) #9857

Open

os-litant requested review from hotlong and os-zhuang September 2, 2026 13:51

os-zhuang approved these changes Sep 2, 2026

View reviewed changes

os-zhuang marked this pull request as ready for review September 2, 2026 14:06

os-zhuang enabled auto-merge September 2, 2026 14:06

os-zhuang added this pull request to the merge queue Sep 2, 2026

Merged via the queue into main with commit d80140c Sep 2, 2026
39 checks passed

os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40

os-project-manager mentioned this pull request Sep 2, 2026

[PM seat] director(项目总监) — 🟢 os-warren（第 14 场，决裁 + 契约复审） #12708

Open

os-sam mentioned this pull request Sep 2, 2026

[finding] The published skill reference index labels data/query.zod.ts — the whole QueryAST — "Sort Node", because its first JSDoc block is SortNode's #14441

Closed

Navigation Menu

Uh oh!

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

os-litant commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

os-litant commented Sep 2, 2026

The two-file diff

Reverse verification — the ratchet red → green pair

Gates — head sha 3e1a218e

Labels

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gates — head sha `3e1a218e`